mirror of
https://github.com/svemagie/indiekit-endpoint-activitypub.git
synced 2026-04-02 15:44:58 +02:00
12454749ad
27 issues fixed from multi-dimensional code review (4 Critical, 6 High, 11 Medium, 6 Low): Security (Critical): - Escape HTML in OAuth authorization page to prevent XSS (C1) - Add CSRF protection to OAuth authorize flow (C2) - Replace bypassable regex sanitizer with sanitize-html library (C3) - Enforce OAuth scopes on all Mastodon API routes (C4) Security (Medium/Low): - Fix SSRF via DNS resolution before private IP check (M1) - Add rate limiting to API, auth, and app registration endpoints (M2) - Validate redirect_uri on POST /oauth/authorize (M4) - Fix custom emoji URL injection with scheme validation + escaping (M5) - Remove data: scheme from allowed image sources (L6) - Add access token expiry (1hr) and refresh token rotation (90d) (M3) - Hash client secrets before storage (L3) Architecture: - Extract batch-broadcast.js — shared delivery logic (H1a) - Extract init-indexes.js — MongoDB index creation (H1b) - Extract syndicator.js — syndication logic (H1c) - Create federation-actions.js facade for controllers (M6) - index.js reduced from 1810 to ~1169 lines (35%) Performance: - Cache moderation data with 30s TTL + write invalidation (H6) - Increase inbox queue throughput to 10 items/sec (H5) - Make account enrichment non-blocking with fire-and-forget (H4) - Remove ephemeral getReplies/getLikes/getShares from ingest (M11) - Fix LRU caches to use true LRU eviction (L1) - Fix N+1 backfill queries with batch $in lookup (L2) UI/UX: - Split 3441-line reader.css into 15 feature-scoped files (H2) - Extract inline Alpine.js interaction component (H3) - Reduce sidebar navigation from 7 to 3 items (M7) - Add ARIA live regions for dynamic content updates (M8) - Extract shared CW/non-CW content partial (M9) - Document form handling pattern convention (M10) - Add accessible labels to functional emoji icons (L4) - Convert profile editor to Alpine.js (L5) Audit: documentation-central/audits/2026-03-24-activitypub-code-review.md Plan: documentation-central/plans/2026-03-24-activitypub-audit-fixes.md
46 lines
2.2 KiB
JavaScript
46 lines
2.2 KiB
JavaScript
/**
|
|
* Media endpoints for Mastodon Client API.
|
|
*
|
|
* POST /api/v2/media — upload media attachment (stub — returns 422 until storage is configured)
|
|
* POST /api/v1/media — legacy upload endpoint (redirects to v2)
|
|
* GET /api/v1/media/:id — get media attachment status
|
|
* PUT /api/v1/media/:id — update media metadata (description/focus)
|
|
*/
|
|
import express from "express";
|
|
import { tokenRequired } from "../middleware/token-required.js";
|
|
import { scopeRequired } from "../middleware/scope-required.js";
|
|
|
|
const router = express.Router(); // eslint-disable-line new-cap
|
|
|
|
// ─── POST /api/v2/media ─────────────────────────────────────────────────────
|
|
|
|
router.post("/api/v2/media", tokenRequired, scopeRequired("write", "write:media"), (req, res) => {
|
|
// Media upload requires multer/multipart handling + storage backend.
|
|
// For now, return 422 so clients show a user-friendly error.
|
|
res.status(422).json({
|
|
error: "Media uploads are not yet supported on this server",
|
|
});
|
|
});
|
|
|
|
// ─── POST /api/v1/media (legacy) ────────────────────────────────────────────
|
|
|
|
router.post("/api/v1/media", tokenRequired, scopeRequired("write", "write:media"), (req, res) => {
|
|
res.status(422).json({
|
|
error: "Media uploads are not yet supported on this server",
|
|
});
|
|
});
|
|
|
|
// ─── GET /api/v1/media/:id ──────────────────────────────────────────────────
|
|
|
|
router.get("/api/v1/media/:id", tokenRequired, scopeRequired("read", "read:statuses"), (req, res) => {
|
|
res.status(404).json({ error: "Record not found" });
|
|
});
|
|
|
|
// ─── PUT /api/v1/media/:id ──────────────────────────────────────────────────
|
|
|
|
router.put("/api/v1/media/:id", tokenRequired, scopeRequired("write", "write:media"), (req, res) => {
|
|
res.status(404).json({ error: "Record not found" });
|
|
});
|
|
|
|
export default router;
|