fix: filter out self-interactions from own Bluesky account

This commit is contained in:
svemagie
2026-03-14 14:01:44 +01:00
parent f8f595fe8d
commit 4f1440a634

View File

@@ -0,0 +1,126 @@
/**
* Patch: filter out self-interactions from own Bluesky account.
*
* When posts are syndicated to Bluesky, the resulting Bluesky post can
* generate notifications (likes, reposts, mentions) attributed to the
* site owner's own account. These self-interactions should not appear
* as inbound interactions.
*
* Two-pronged fix:
* 1. scheduler.js skip storing new notifications where the author
* handle matches BLUESKY_IDENTIFIER / BLUESKY_HANDLE.
* 2. conversations.js strip self-authored items from API responses so
* any already-stored entries are hidden immediately.
*/
import { access, readFile, writeFile } from "node:fs/promises";
const schedulerCandidates = [
"node_modules/@rmdes/indiekit-endpoint-conversations/lib/polling/scheduler.js",
"node_modules/@indiekit/indiekit/node_modules/@rmdes/indiekit-endpoint-conversations/lib/polling/scheduler.js",
];
const controllerCandidates = [
"node_modules/@rmdes/indiekit-endpoint-conversations/lib/controllers/conversations.js",
"node_modules/@indiekit/indiekit/node_modules/@rmdes/indiekit-endpoint-conversations/lib/controllers/conversations.js",
];
const patchSpecs = [
{
name: "conversations-bluesky-scheduler-self-filter",
candidates: schedulerCandidates,
marker: "// Skip self-interactions",
oldSnippet: ` let stored = 0;
for (const notification of result.items) {
let canonicalUrl = null;`,
newSnippet: ` let stored = 0;
// Derive own handle from identifier (strip leading @)
const ownBskyHandle = (credentials.identifier || "").replace(/^@+/, "").toLowerCase();
for (const notification of result.items) {
// Skip self-interactions (e.g. own account liking/reposting a syndicated post)
if (ownBskyHandle && (notification.author?.handle || "").toLowerCase() === ownBskyHandle) {
continue;
}
let canonicalUrl = null;`,
},
{
name: "conversations-bluesky-api-self-filter",
candidates: controllerCandidates,
marker: "// Filter out self-interactions from own Bluesky account",
oldSnippet: ` const children = items.map(conversationItemToJf2);
response.set("Cache-Control", "public, max-age=60");`,
newSnippet: ` // Filter out self-interactions from own Bluesky account
const _selfBskyHandle = (process.env.BLUESKY_IDENTIFIER || process.env.BLUESKY_HANDLE || "").replace(/^@+/, "").toLowerCase();
if (_selfBskyHandle) {
const _selfBskyUrl = "https://bsky.app/profile/" + _selfBskyHandle;
items = items.filter(item => (item.author?.url || "").toLowerCase() !== _selfBskyUrl);
}
const children = items.map(conversationItemToJf2);
response.set("Cache-Control", "public, max-age=60");`,
},
];
async function exists(filePath) {
try {
await access(filePath);
return true;
} catch {
return false;
}
}
const checkedFiles = new Set();
const patchedFiles = new Set();
for (const spec of patchSpecs) {
let foundAnyTarget = false;
for (const filePath of spec.candidates) {
if (!(await exists(filePath))) {
continue;
}
foundAnyTarget = true;
checkedFiles.add(filePath);
const source = await readFile(filePath, "utf8");
if (spec.marker && source.includes(spec.marker)) {
continue;
}
if (!source.includes(spec.oldSnippet)) {
continue;
}
const updated = source.replace(spec.oldSnippet, spec.newSnippet);
if (updated === source) {
continue;
}
await writeFile(filePath, updated, "utf8");
patchedFiles.add(filePath);
}
if (!foundAnyTarget) {
console.log(`[postinstall] ${spec.name}: no target files found`);
}
}
if (checkedFiles.size === 0) {
console.log("[postinstall] No conversations bluesky self-filter files found");
} else if (patchedFiles.size === 0) {
console.log("[postinstall] conversations bluesky self-filter patches already applied");
} else {
console.log(
`[postinstall] Patched conversations bluesky self-filter in ${patchedFiles.size}/${checkedFiles.size} file(s)`,
);
}